search

Giorgi / DuckDB.NET

Bindings and ADO.NET Provider for DuckDB
https://duckdb.net
MIT License
356 stars 62 forks source link

Zero IntPtr for string fails #23

Closed RPalejiya closed 2 years ago

RPalejiya commented 2 years ago

Here is the test that fails with ADO wrapper.


            command.CommandText = "PRAGMA show('integers');";
             reader = command.ExecuteReader();
            PrintQueryResults(reader);

To Fix, I had changed DuckDbDataReader.cs for following code to check for zero IntPtr.

        public override string GetString(int ordinal)
        {
            var unmanagedString = PlatformIndependentBindings.NativeMethods.DuckDBValueVarchar(queryResult, ordinal, currentRow);
            return (unmanagedString.Equals(IntPtr.Zero)) ? "" : unmanagedString.ToManagedString();
        }

Thanks, Ravi

Giorgi commented 2 years ago

Can you send a PR?