search

Giorgi / DuckDB.NET

Bindings and ADO.NET Provider for DuckDB
https://duckdb.net
MIT License
356 stars 62 forks source link

Add bindings for appender API. #32

Closed kmosegaard closed 2 years ago

kmosegaard commented 2 years ago

This PR adds bindings for the appender API. Definitions are sourced from here: https://duckdb.org/docs/api/c/appender. Not all definitions are defined in this PR but is more than enough for my use-case.

What do you think, so I add the last ones for completeness?

Giorgi commented 2 years ago

If you can it would be nice to have the full API for the appender.

Giorgi commented 2 years ago

@kmosegaard Do you plan to resolve the conflicts or should I close the PR?

kmosegaard commented 2 years ago

Resolved conflicts.

I've also added the 'xunit.runner.visualstudio' because I wasn't able to run unit tests through 'dotnet test' without. On test seems to be failing but is unrelated to this change?

Giorgi commented 2 years ago

Yes, it looks like a concurrency issue between tests.

Giorgi commented 2 years ago

Thanks @kmosegaard!