search

Giorgi / DuckDB.NET

Bindings and ADO.NET Provider for DuckDB
https://duckdb.net
MIT License
343 stars 62 forks source link

Call DuckDBDestroyResult even on success #46

Closed pkese closed 2 years ago

pkese commented 2 years ago

DuckDb API doca are suggesting to call duckdb_destroy_result after each query to
"de-allocate all memory allocated for that connection".

In DuckDDCommand.ExecuteNonQuery we called DuckDBDestroyResult only for error path,
but we didn't destroy the result for the success path.

Giorgi commented 2 years ago

Can you format the code?

pkese commented 2 years ago

Sure, except I'm not sure what to format (I'm not using visual studio so maybe my code looks different than yours).

Could you include .editorconfig or some specs of how code should formatted or linted.

Giorgi commented 2 years ago

Opening braces need to be on a new line.