Giorgi / DuckDB.NET

Bindings and ADO.NET Provider for DuckDB
https://duckdb.net
MIT License
411 stars 69 forks source link

Fix tests for DuckDB v5 #63

Closed unconverged closed 2 years ago

unconverged commented 2 years ago

We now have failing builds. The reason is that the tests with UPDATE statements and invalid parameter values are failing. Apparently, that is because DuckDB does not execute UPDATE statements on empty tables.

Giorgi commented 2 years ago

Do you know if that is a new feature in 0.5.0 or a bug? I asked it here but didn't get any response: https://github.com/duckdb/duckdb/discussions/4640

unconverged commented 2 years ago

This seems to be a feature, an optimisation of some kind. DuckDB ignores any UPDATE statement for an empty table, not only erroneous. As you can see from the PR, I've updated tests that use the correct parameter order, as they reported no affected rows.