search

Giorgi / DuckDB.NET

Bindings and ADO.NET Provider for DuckDB
https://duckdb.net
MIT License
356 stars 62 forks source link

Implement datareader methods GetValue, GetType and NextResult #9

Closed travis-leith closed 3 years ago

travis-leith commented 3 years ago

These are required for Dapper to do the automatic mapping from query to object.

travis-leith commented 3 years ago

This one was fairly simple. I have the changes on a branch on my fork called "reader". However it assumes the multiple connections commits so lets get that wrapped up before I submit a PR for this.

travis-leith commented 3 years ago

https://github.com/travis-leith/DuckDB.NET/tree/reader

Giorgi commented 3 years ago

If you can send it in a PR that doesn't depend on multiple connections I will merge it.

travis-leith commented 3 years ago

@Giorgi

Just FYI, I am currently integrating the latest changes in a project that previously used sqlite. Should take me a couple of hours. Once done I can confirm correctness based on my unit tests and if good you can release another nuget.

Giorgi commented 3 years ago

@travis-leith It will be interesting if you can share performance comparison between SQLite and DuckDb.

travis-leith commented 3 years ago

@Giorgi unfortunately that is not really practical right now, since I am prototyping a component of a bigger project, started using sqlite, realized it was not appropriate when I got to the point of ingesting large amounts of data and then decided to switch to DuckDB. So I don't have anything meaty to test yet. But all my tests have now passed using the latest stuff here, so I think it is safe to release a new nuget.

Giorgi commented 3 years ago

I see but did DuckDB live up to your expectations when you loaded large amounts of data?

Giorgi commented 3 years ago

@travis-leith New version published.