Closed acinep closed 1 year ago
I added additional test cases with non-zero microseconds. I think its probably fine to use these instead of the existing cases (keeping the total at three per fixture) but I didn't want to remove existing cases without getting the OK to do so.
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
DuckDB.NET/Utils.cs | 4 | 6 | 66.67% | ||
DuckDB.NET/DuckDBTimestamp.cs | 0 | 3 | 0.0% | ||
DuckDB.NET/DuckDBTimeOnly.cs | 6 | 11 | 54.55% | ||
<!-- | Total: | 12 | 22 | 54.55% | --> |
Files with Coverage Reduction | New Missed Lines | % | ||
---|---|---|---|---|
DuckDB.NET/DuckDBTimestamp.cs | 5 | 46.67% | ||
<!-- | Total: | 5 | --> |
Totals | |
---|---|
Change from base Build 4609338767: | -1.0% |
Covered Lines: | 705 |
Relevant Lines: | 824 |
Resolves issue #74
The parsing to/from ticks is a little clunky as the netstandard2 and net6 DateTime API don't support microsecond properties. This is available in net7+ which would clean a lot of this up.
Feedback welcome