Closed ydirson closed 8 years ago
Thanks, sorry I didn't see this earlier. I'll try to pull it this week.
On Sun, Aug 18, 2013 at 01:52:35PM -0700, Giorgio Regni wrote:
Thanks, sorry I didn't see this earlier. I'll try to pull it this week.
Reply to this email directly or view it on GitHub: https://github.com/GiorgioRegni/Binaural-Beats/pull/8#issuecomment-22839258
Oh, I realized afterwards that it is not necessary, the ant files are generated ant should in fact not be committed - sorry :(
What about the gitignore lines? Le 19 août 2013 18:13, "Yann Dirson" notifications@github.com a écrit :
On Sun, Aug 18, 2013 at 01:52:35PM -0700, Giorgio Regni wrote:
Thanks, sorry I didn't see this earlier. I'll try to pull it this week.
Reply to this email directly or view it on GitHub:
https://github.com/GiorgioRegni/Binaural-Beats/pull/8#issuecomment-22839258
Oh, I realized afterwards that it is not necessary, the ant files are generated ant should in fact not be committed - sorry :(
— Reply to this email directly or view it on GitHubhttps://github.com/GiorgioRegni/Binaural-Beats/pull/8#issuecomment-22883275 .
It's still correct, as the other patch is. I'll repush.
I'm not going to use eclipse anytime soon, so I'm set to use ant for builds. While I attempted the build, I stumbled on a couple of issues. This patch series contains the ones that were straightforward to fix.