GiorgosXou / TUIFIManager

A cross-platform terminal-based termux-oriented file manager (and component), meant to be used with a Uni-Curses project or as is.
GNU General Public License v3.0
684 stars 13 forks source link

Use exact Imports instead of wildcards. #54

Closed Sigmanificient closed 1 year ago

Sigmanificient commented 1 year ago

In python wildcard imports should be avoided because they create namespace pollution. Everything imported is added to the global dictionary as is, which often add a lot more than needed.

Additionally, wildcard imports can make it difficult for others reading your code to understand where the names being used are coming from. It is generally better to use explicit imports for the names that you need, rather than using wildcard imports.

Finally i added the missing requirements.txt file to declare uni-curses as a dependency for this package. This way you can use pip install -r requirements.txt instead of having to find the missing lib to install.