search

GiovanH / unofficial-homestuck-collection

An offline collection of Homestuck and its related works.
GNU General Public License v3.0
25 stars 3 forks source link

Why are we doing this? This requires everyone to h... #105

Closed github-actions[bot] closed 3 years ago

github-actions[bot] commented 3 years ago

Why are we doing this? This requires everyone to have steam installed, and gives a cryptic protocol error if they don't.

If we must do this we should check for a steam installation, eat least

https://github.com/Bambosh/unofficial-homestuck-collection/blob/611ca34fe82644796c901f114e6b35b6db08472b/src/background.js#L542


ipcMain.handle('steam-open', async (event, browserUrl) => {
  // TODO: Why are we doing this? This requires everyone to have steam installed, and gives a cryptic protocol error if they don't.
  // If we must do this we should check for a steam installation, eat least
  const steamUrl = browserUrl.replace(/http(s){0,1}:\/\/[\w.]*steampowered.com\/app/i, 'steam://url/StoreAppPage')

  if (app.getApplicationNameForProtocol(steamUrl)) {
    await shell.openExternal(steamUrl)
  } else {
ndex 804c2ff..6efc75a 100644
++ b/src/components/SystemPages/Log.vue

198a89f6a4b8c30f87507148b8ce1b9cf5e6fec2

GiovanH commented 3 years ago

never mind, getApplicationNameForProtocol handles everything described here.