search

GiovanH / unofficial-homestuck-collection

An offline collection of Homestuck and its related works.
GNU General Public License v3.0
37 stars 4 forks source link

"Hide fullscreen header" setting doesn't work when zoomed in/out #511

Closed Mawile0 closed 8 months ago

Mawile0 commented 1 year ago

Describe the bug When you zoom in/out using the ctrl key with the setting "Hide fullscreen header" checked, the header reappears.

To Reproduce Steps to reproduce the behavior:

  1. Go to settings
  2. Enable "hide fullscreen header"
  3. Press F11 to go into full screen
  4. Using the ctrl key and the +/- keys or the ctrl key and your scroll wheel, zoom in or out of the application.
  5. The header reappears.

Expected behavior When you zoom in/out in full screen with the "hide fullscreen header" setting enabled, the header should stay hidden.

Screenshots The_Unofficial_Homestuck_Collection_veLHOwZzEy

Desktop (please complete the following information):

Additional context This issue occurs in the versions I listed, but I didn't test 2.0.5 cuz I didn't wanna redownload it. I also tested if any mods could have caused the issue since I have a lot of those, but it still happened even when I disabled all of my mods and refreshed the application.

GiovanH commented 1 year ago

well there's the problem https://github.com/Bambosh/unofficial-homestuck-collection/commits?author=recordcrash

recordcrash commented 1 year ago

whoops, my bad

GiovanH commented 1 year ago

the inner/outer difference is a weird one but I went ahead and updated the whole thing