Banner properties should be set in data, not code

GiovanH / unofficial-homestuck-collection

An offline collection of Homestuck and its related works.

GNU General Public License v3.0

25 stars 3 forks source link

Banner properties should be set in data, not code #91

Closed github-actions[bot] closed 3 years ago

github-actions[bot] commented 3 years ago

Banner properties should be set in data, not code

https://github.com/Bambosh/unofficial-homestuck-collection/blob/e84be89aec01c4e48fd7175d1e52cfb4f853960c/src/components/Page/PageBanner.vue#L24

        }
    },
    // TODO: Banner properties should be set in data, not code
    computed: {
        banner() {
            let result = undefined
ndex cbbd2e8..ff99f0a 100644
++ b/src/components/SpecialPages/TzPassword.vue

67eeea54cf2e9a37dd70fe5f232371db6808dc88

GiovanH commented 3 years ago

duplicate of #95