search

GiovanH / unofficial-homestuck-collection

An offline collection of Homestuck and its related works.
GNU General Public License v3.0
25 stars 3 forks source link

These specific banner designations should be part ... #95

Closed github-actions[bot] closed 2 years ago

github-actions[bot] commented 3 years ago

These specific banner designations should be part of data, not code

https://github.com/Bambosh/unofficial-homestuck-collection/blob/079b40e9c61449d8284e2a9e9aec514331cc61f8/src/components/Page/PageBanner.vue#L26

    // TODO: Banner properties should be set in data, not code
    computed: {
        // TODO: These specific banner designations should be part of data, not code
        banner() {
            let result = undefined
            let num = parseInt(this.page.pageId)
ndex fb0d37f..4b6147b 100644
++ b/src/components/Socials/MagicalJourney.vue

0f8b59d06c666a84b8541594c04d92cf81ee57a9

GiovanH commented 3 years ago

These scratch banners are very much metadata for the original pages; should this all actually be moved to the asset pack?