search

GiovanniBruno22 / PythonBeginners

This repository is meant for new developers to submit first pull requests to and get reviews from peers.
17 stars 22 forks source link

Create a script that when run shows the current time for London/New York/Mumbai #1

Closed GiovanniBruno22 closed 1 year ago

GiovanniBruno22 commented 1 year ago

Hey! it would be nice if someone could code a script that shows the current time for London/New York/Mumbai when it is ran from terminal.

ihavemadefire commented 1 year ago

Hi Giovanni, Just submitted PR#2 at https://github.com/GiovanniBruno22/PythonBeginners/pull/2 Let me know if it LGTY.

GiovanniBruno22 commented 1 year ago

Thanks a lot for submitting this repo's first ever PR! I really appreciate your help 😄 I left a few comments on the PR, as soon as those are addressed I will merge the changes in!

ihavemadefire commented 1 year ago

I don't see the comments on the PR. Let me know what changes you need to see and I'll get them pushed. 😊

On Mon, Jul 24, 2023 at 4:22 PM Giovanni Samuel Bruno < @.***> wrote:

Thanks a lot for submitting this repo's first ever PR! I really appreciate your help 😄 I left a few comments on the PR, as soon as those are addressed I will merge the changes in!

— Reply to this email directly, view it on GitHub https://github.com/GiovanniBruno22/PythonBeginners/issues/1#issuecomment-1648632571, or unsubscribe https://github.com/notifications/unsubscribe-auth/AGLIVO76FM4QQS57YOPHZ23XR3RQLANCNFSM6AAAAAA2VMSQIY . You are receiving this because you were assigned.Message ID: @.***>

GiovanniBruno22 commented 1 year ago

Apologies for that, I forgot to click on publish review 🤣, you should be able to see the comments on your PR now.

GiovanniBruno22 commented 1 year ago

This has been resolved, thanks a lot @ihavemadefire for your contribution, I will mark this issue as complete.