search

GiovanniBruno22 / PythonBeginners

This repository is meant for new developers to submit first pull requests to and get reviews from peers.
17 stars 22 forks source link

Created roots_of_quadratic.py #14

Closed githubsharat closed 1 year ago

githubsharat commented 1 year ago

Wrote a python code that finds out roots of a quadratic equation. I am learning open source contribution. Please give me any feedback if possible. Thank you.

githubsharat commented 1 year ago

I just made the commit: 5ecaaad2f2948b670e6150ae2407d3d63a58f6b1

Included all the suggested changes. I am sorry again about the earlier accidental resolve. Please suggest me any further feedback if you would like. Thank you very much!

GiovanniBruno22 commented 1 year ago

Merging this in!

githubsharat commented 1 year ago

This looks good to me! thank you so much for your contribution @githubsharat !

It’s my pleasure. Thank you very much for your feedback and opportunity to learn open-source contribution! @GiovanniBruno22