GiovanniSalmeri / yellow-link

Internal and external links.
GNU General Public License v2.0
3 stars 1 forks source link

Deprecated: preg_match() Error #2

Closed pftnhr closed 1 year ago

pftnhr commented 1 year ago

Hi Giovanni,

I'm getting this error message on page where I'm using a link text ([link https://domain.tld "Nice link text"]): Deprecated: preg_match(): Passing null to parameter #2 ($subject) of type string is deprecated in /www/htdocs/.../.../system/extensions/link.php on line 47

GiovanniSalmeri commented 1 year ago

Hello! Thank you very much for spotting this, now it should be fixed. Can you confirm?

pftnhr commented 1 year ago

The error message is gone but now there is a line break in the output.

Bildschirmfoto 2023-08-27 um 18 54 05
GiovanniSalmeri commented 1 year ago

Unfortunately I cannot reproduce the problem... Could you copy the exact markdown text which produces this output with those extra line breaks?

pftnhr commented 1 year ago

Of course:

[^1]: [link https://nova.app]
[^2]: [link https://panic.com]
[^3]: [link https://www.panic.com/transmit]
[^4]: [link why-yellow]
[^5]: [link https://sass-lang.com]
[^6]: [link https://brew.sh]
[^7]: [link https://emmet.io]
[^8]: [link https://github.com/beautify-web/js-beautify]
[^9]: [link https://beautifier.io]
GiovanniSalmeri commented 1 year ago

Should be fixed now, I had made a stupid change 😊 which I have now reverted.

pftnhr commented 1 year ago

Fantastic Giovanni, now everything fits.

Thank you very much!