Closed timholy closed 8 years ago
CC also @Godesimo.
Oops, misspelled that (sorry): @Godisemo.
I'd say tag it, I'll help with issues if they crop up.
I expect the Gadfly/Immerse backends in Plots might break once it's tagged, but (although I may not want it) it's best to rip the band-aid off and see what the cut looks like...
On Mon, Nov 16, 2015 at 8:50 AM, Shashi Gowda notifications@github.com wrote:
I'd say tag it, I'll help with issues if they crop up.
— Reply to this email directly or view it on GitHub https://github.com/dcjones/Compose.jl/issues/171#issuecomment-157031671.
@tbreloff do you want to tag a new version of Plots with a max-version of Gadfly/Compose, so that your users can continue using it while you fix the breakage?
If you want to test the Immerse backend, just update to master on Compose and teh/measures
on Immerse. I just ran it, and all the Gadfly tests looked fine by eye (PyPlot had some issues on my system, though).
That's a good idea. I've been wanting to tag a new version anyways. (Tim: if you're seeing any issues on the latest Plots master, can you open an issue with the commands you used?)
On Mon, Nov 16, 2015 at 9:23 AM, Avik Sengupta notifications@github.com wrote:
@tbreloff https://github.com/tbreloff do you want to tag a new version of Plots with a max-version of Gadfly/Compose, so that your users can continue using it while you fix the breakage?
— Reply to this email directly or view it on GitHub https://github.com/dcjones/Compose.jl/issues/171#issuecomment-157045505.
For the error at the top, see https://github.com/JuliaLang/julia/pull/14015.
Fixing the Colors parsing unveiled the underlying cause of the error (passing a Colorant into the constructor of Gadfly's HLineGeometry/VLineGeometry). After fixing (and with the Colors PR) the Plots tests are passing for Gadfly.
(Immerse is untested... I can't even clone it without breaking Pkg
completely. I'll wait to test until this tagging smoke clears.)
Fixed by https://github.com/JuliaLang/METADATA.jl/pull/4051. @tbreloff, hopefully the Pkg mess is cleared now?
For other folks intimately involved with this package (@shashi, @darwindarak, etc), what do people think about tagging a new release? Currently the experience for Immerse users is awful because of long screenfulls of deprecation warnings; this is fixed by #167 and https://github.com/JuliaGraphics/Immerse.jl/pull/47. Locally (probably because I'm using https://github.com/JuliaGraphics/Immerse.jl/pull/47) I'm also getting Pkg errors:
I'm going to try to fix this separately, but in the meantime it would be great to tag a new release of Compose and Gadfly. Do folks think we can deal with any problems that crop up in the absence of @dcjones? (Hopefully he's having a lovely time sunbathing in Fiji or scaling Mt. Everest or something similarly exciting, and not suffering from RSI and needing to take a break from typing. Or perhaps he's just swamped by other duties, an all-too familiar state for me.)
My main concern is that the Measures.jl transition is a pretty big one.