search

GiovineItalia / Compose.jl

Declarative vector graphics
http://giovineitalia.github.io/Compose.jl/latest/
Other
248 stars 81 forks source link

fix Fontconfig on julia 0.7 #346

Closed bjarthur closed 5 years ago

bjarthur commented 5 years ago

https://github.com/GiovineItalia/Compose.jl/pull/342 nicely fixed the pango dependency hack for julia 1.0, but broke it completely on 0.7. this fixes it.

@timholy this is pretty straightforward, but any comments?

codecov-io commented 5 years ago

Codecov Report

Merging #346 into master will increase coverage by 0.85%. The diff coverage is 100%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #346      +/-   ##
==========================================
+ Coverage   38.09%   38.95%   +0.85%     
==========================================
  Files          18       18              
  Lines        3124     3127       +3     
==========================================
+ Hits         1190     1218      +28     
+ Misses       1934     1909      -25
Impacted Files Coverage Δ
src/Compose.jl 27.38% <ø> (+7.14%) :arrow_up:
src/pango.jl 21.48% <100%> (+21.48%) :arrow_up:
src/pgf_backend.jl 47.08% <0%> (-1.25%) :arrow_down:
src/fontfallback.jl 46.07% <0%> (-0.53%) :arrow_down:

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update a87b2b2...11253c8. Read the comment docs.