Closed bjarthur closed 4 years ago
Merging #392 into master will decrease coverage by
0.04%
. The diff coverage is30.23%
.
@@ Coverage Diff @@
## master #392 +/- ##
==========================================
- Coverage 43.05% 43.01% -0.05%
==========================================
Files 18 18
Lines 3226 3229 +3
==========================================
Hits 1389 1389
- Misses 1837 1840 +3
Impacted Files | Coverage Δ | |
---|---|---|
src/svg.jl | 73.85% <100%> (-0.09%) |
:arrow_down: |
src/fontfallback.jl | 53.57% <28.57%> (+0.17%) |
:arrow_up: |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 1749b92...55ddc75. Read the comment docs.
this might be good to go. output now looks like this:
moreover, the output is now identical irrespective of whether Fontconfig is imported or not. one caveat here is that to make them the same, the vertical shift specified by pango is now ignored because it is in absolute points, and seemingly it doesn't know the font size at that line in the code. so i changed it to use the same relative shift used by fontfallback, which is in "em" units.
also, to make sure that the output remains the same with or without Fontconfig i refactored the unit tests to run each example in a separate julia process. hard to test for this in the same session as once you've imported Fontconfig you can't unimport it.
fixes this problem: