GiovineItalia / Compose.jl

Declarative vector graphics

http://giovineitalia.github.io/Compose.jl/latest/

Other

248 stars 83 forks source link

Compose v0.9 #400

Closed Mattriks closed 4 years ago

bjarthur commented 4 years ago

there are breaking changed that merit a bump in the minor number?

codecov-commenter commented 4 years ago

Codecov Report

Merging #400 into master will not change coverage. The diff coverage is n/a.

@@           Coverage Diff           @@
##           master     #400   +/-   ##
=======================================
  Coverage   44.24%   44.24%           
=======================================
  Files          18       18           
  Lines        3390     3390           
=======================================
  Hits         1500     1500           
  Misses       1890     1890

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update edeb921...8f900c9. Read the comment docs.

Mattriks commented 4 years ago

This is needed for GiovineItalia/Gadfly.jl#1459, and I thought minor releases could include new features, such as the handling of missing values (which is an important step for Compose and Gadfly). I can change to a patch release, if you think that is sufficient?

Mattriks commented 4 years ago

Also, a user could write code using Compose 0.9, which is not compatible with Compose 0.8.x, because with Compose 0.9 I could remove skipmissing from code, but that would fail on Compose 0.8.x.

Mattriks commented 4 years ago

@bjarthur I see your thumbs up - great! I will merge and register

bjarthur commented 4 years ago

IIRC before 1.0 in semvar anything goes in terms of features and compatibility when bumping the ~major~, minor, or patch numbers. given that flexibility, i'd suggest the next version of Compose after the just-merged 0.9 doesn't necessary have to be 1.0. better in my mind that it be 0.10.0. having restrictions on backward compatibility is a pain. it was a mistake in my mind to release Gadfly 1.0 so soon. ditto for julia 1.0.

Mattriks commented 4 years ago

I agree, minor versions of Compose should continue with 0.10.x 0.11.x etc. There are some things in Compose which still need a bit of work, as can be seen on the issues page.