avoid using internal `.data` field

KristofferC commented 4 months ago

The previous way is not the correct way of getting a string out of an IOBuffer (fails on 1.11 for example)

KristofferC commented 4 months ago

cc @bjarthur

bjarthur commented 4 months ago

thanks! can you add the missing right paren?

KristofferC commented 4 months ago

classic in-browser editing

codecov-commenter commented 4 months ago

Codecov Report

All modified and coverable lines are covered by tests :white_check_mark:

Project coverage is 46.37%. Comparing base (8e7e1a2) to head (c9e04d0).

:exclamation: Your organization needs to install the Codecov GitHub app to enable full functionality.

Additional details and impacted files

```diff @@ Coverage Diff @@ ## master #441 +/- ## ========================================== + Coverage 46.27% 46.37% +0.10% ========================================== Files 18 18 Lines 3702 3728 +26 ========================================== + Hits 1713 1729 +16 - Misses 1989 1999 +10 ```

:umbrella: View full report in Codecov by Sentry.
:loudspeaker: Have feedback on the report? Share it here.

GiovineItalia / Compose.jl

avoid using internal `.data` field #441

Codecov Report