search

Gip-Gip / egui-plotter

Simple to use utilties for integrating plotter into egui
MIT License
40 stars 15 forks source link

lock timechart behind feature #3

Closed bananaturtlesandwich closed 1 year ago

bananaturtlesandwich commented 1 year ago

just a pr for #2 which puts the timechart and timedata behind the timechart feature - more features can always be made for other charts in the future also made the feature rely on the instant crate which works on wasm and actually doesn't add bloat on native because it falls back to the standard library

bananaturtlesandwich commented 1 year ago

might make a PR in future to let the examples compile to wasm so there can be web demos

Gip-Gip commented 1 year ago

Will get to it tonight, thanks again!

bananaturtlesandwich commented 1 year ago

No problem! This crate came around at the perfect time for me so it's my pleasure

Gip-Gip commented 1 year ago

Just added a user notice to remind them to enable the feature, and also enabled the feature so that it is tested with cargo check/test. Documentation will also now be automatically generated for the feature when the crate is published.

Gip-Gip commented 1 year ago

To clarify, it is not a default feature, it is only enabled during testing.

bananaturtlesandwich commented 1 year ago

Great!