Giphy / GiphyAPI

Public facing API docs, notes and more
1.9k stars 282 forks source link

term suggestion always returning null value #158

Closed navanindra closed 3 years ago

navanindra commented 6 years ago

m implementing the sdk in obj-c, nd using term suggestion for search bar..

when a space is inserted it will call the term suggestion but it returns null value heres the code::: [self.client termSuggestions:searchBar.text completionHandler:^(GPHListTermSuggestionResponse _Nullable response, NSError _Nullable error) { NSLog(@"response\n%@",[response data]); }];

dfinkler commented 6 years ago

Hi @navanindra - thanks for the bug report! We're looking into the issue now and will be in touch shortly with a resolution.

navanindra commented 6 years ago

Hi @dfinkler have you got the resolution for the same??? well I have to finalise the app...

dfinkler commented 6 years ago

@navanindra we had our mobile team look into the issue and they were not able to replicate the bug. Can you provide me with the specific request that's returning the unexpected value and what specific lines of code in the SDK that are relevant. Thanks!

navanindra commented 6 years ago

On Mon, 5 Feb 2018 at 9:07 PM, danfinkler notifications@github.com wrote:

@navanindra https://github.com/navanindra we had our mobile team look into the issue and they were not able to replicate the bug. Can you provide me with the specific request that's returning the unexpected value and what specific lines of code in the SDK that are relevant. Thanks!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Giphy/GiphyAPI/issues/158#issuecomment-363121631, or mute the thread https://github.com/notifications/unsubscribe-auth/AZzJ-nF42Dk7-xo64fTNLQzvPBcOqcA9ks5tRyBRgaJpZM4RRZc3 .

Well there is not much in the code I can describe theoretically. When m calling termsuggestion with some text like cartoon, api returns null value i will update my comment with code asap meanwhile if u think my description is enough to get into the bug pls revert for the same and thank you for yoir attention.

dfinkler commented 6 years ago

@navanindra we have our mobile engineering team looking into your bug. Can you send me the API requests you are issuing that return the bad response. You can include them in this ticket - just mask out the API Key you are using in your requests.

eg, http://api.giphy.com/search/gifs?q=this+is+my+search+term&api_key=FOO

Thank you!

navanindra commented 6 years ago

I'm using the IOS sdk provided by you guys, everything is working fine except term suggestion... m sending you the fun m using

-(void)searchBar:(UISearchBar )searchBar textDidChange:(NSString )searchText {

if ([searchText rangeOfCharacterFromSet:[NSCharacterSet

whitespaceAndNewlineCharacterSet]].location != NSNotFound) {

    [self.client termSuggestions:searchText completionHandler:^(

GPHListTermSuggestionResponse _Nullable response, NSError _Nullable error) {

        NSLog(@"Response\n%@",response.data);

    }];

}

}

NOTE: m using it in Objective c. pls revert if u need anything thing else from my side

On Mon, Feb 26, 2018 at 9:36 PM, danfinkler notifications@github.com wrote:

@navanindra https://github.com/navanindra we have our mobile engineering team looking into your bug. Can you send me the API requests you are issuing that return the bad response. You can include them in this ticket - just mask out the API Key you are using in your requests.

eg, http://api.giphy.com/search/gifs?q=this+is+my+search+term&api_key=FOO

Thank you!

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/Giphy/GiphyAPI/issues/158#issuecomment-368553216, or mute the thread https://github.com/notifications/unsubscribe-auth/AZzJ-nztRu7OCqw4sVqjR6Wncmmztb6wks5tYtaZgaJpZM4RRZc3 .

dfinkler commented 6 years ago

@navanindra we're investigating this further - please stand by and thanks for the bug report.

shwetaatgiphy commented 3 years ago

Hey @navanindra

GIPHY has released newer versions of the iOS SDK since this issue was first created. We hope this issue has been fixed. If not, please do not hesitate to reopen this issue. Thank you.