search

Giphy / GiphyAPI

Public facing API docs, notes and more
1.9k stars 282 forks source link

Missing Callbacks "onGifsFetched" and "onGifsFetchError" in web SDK #219

Closed kevinXmichael closed 4 years ago

kevinXmichael commented 4 years ago

The callbacks onGifsFetched and onGifsFetchError for the web SDK in the js-components especially in the renderGrid function are optional and not called if the fetchGifs function does not return anything.

This makes it currently impossible for me to check and display a hint, if the query does not return any results.

I use Vue.js instead of React and therefore the native web components. I use it like this:

const fetchGifs = new GiphyFetch(apiKey).search(query, { ... })

renderCarousel({
    fetchGifs,
    onGifsFetched: (gifs) => {
        ...
    },
    onGifClick: (gif, event) => {
        ...
    },
    ...
})
shwetaatgiphy commented 4 years ago

Hi @kmschott This looks to be an issue with out Web SDK. Please go ahead and create this issue in that repository so the right team can help out. Thank you for using our SDKs