Move dependencies to Maven

Giphy / giphy-android-sdk

Home of the GIPHY SDK Android example app, along with Android SDK documentation, issue tracking, & release notes.

https://developers.giphy.com/

Mozilla Public License 2.0

94 stars 37 forks source link

Move dependencies to Maven #131

Closed Kiran-Rao closed 3 years ago

Kiran-Rao commented 3 years ago

Hello, Jcenter is shutting down soon. The following dependencies appear to be relying on jcenter:

|    +--- io.alterac.blurkit:blurkit:1.1.1 FAILED
|    +--- com.facebook.fresco:fresco:2.4.0 FAILED
|    +--- com.facebook.fresco:animated-gif:2.4.0 FAILED
|    +--- com.facebook.fresco:animated-base:2.4.0 FAILED
|    +--- com.facebook.fresco:animated-drawable:2.4.0 FAILED
|    +--- com.facebook.fresco:animated-webp:2.4.0 FAILED
|    +--- com.facebook.fresco:webpsupport:2.4.0 FAILED
|    +--- com.facebook.fresco:imagepipeline-okhttp3:2.4.0 FAILED

Kiran-Rao commented 3 years ago

ALexanderLonsky commented 3 years ago

hey @Kiran-Rao, thank you for flagging this. We are aware of those dependencies and it is on our roadmap. As you mentioned, the latest Fresco version is not on Maven yet.

oprisnik commented 3 years ago

Hey! We've released Fresco 2.5.0 tot Maven Central, so you should be able to upgrade now.

ALexanderLonsky commented 3 years ago

@oprisnik hey! thank you for the update, we'll do that soon.

gildor commented 3 years ago

@ALexanderLonsky Is there any chance that something will be done also with blurkit (related issue, looks that no migration is planned)? For now, Giphy is the only library which we use which depends on jcenter dependencies

ALexanderLonsky commented 3 years ago

@gildor of course, I thought just to remove it, because there are more issues with that library like crashes and memory leaks.

ALexanderLonsky commented 3 years ago

@Kiran-Rao, @gildor The issue must be fixed in v2.1.1

Kiran-Rao commented 3 years ago

Thanks @ALexanderLonsky, v2.1.1 appears to have solved this.