search

Giphy / giphy-android-sdk

Home of the GIPHY SDK Android example app, along with Android SDK documentation, issue tracking, & release notes.
https://developers.giphy.com/
Mozilla Public License 2.0
94 stars 37 forks source link

GiphyDialogFragment's list not playing all frames delays #164

Open perracodex opened 2 years ago

perracodex commented 2 years ago

Just by chance while testing different GIFs, I've found one which has all frames with a delay at 80ms, except for the last frame which is set to 480ms. In Giphy's web site the GIF in question plays correctly including taking into account the last frame delay, yet in the GiphyDialogFragment's list seems the last frame delay is ignored giving the impression that it animates faster.

The actual GIF is next:

https://giphy.com/gifs/imoji-laughing-3ohzdQJJ2JGvMSYvdu

Although is a minimal issue, I wanted to point it out just in case.

Update: Found a few more GIFs where the last frame has a longer delay, but the dialog preview doesn't honor it. This one has a 0 delay per frame and a the last with with 3000ms. The GiphyDialogFragment correctly assumes 100ms for the 0 delay frames, yet it ignores the last 3000ms frame. Giphy's webside honors the delay:

https://giphy.com/stickers/cedars-sinai-transparent-abizFdsnUSFfa5qOEm

ALexanderLonsky commented 2 years ago

hey @perracolabs, thanks for flagging this. As you may already know, Giphy SDK uses Facebook Fresco under the hood. It must be an option to take into account the frames' delay. I'll look into it.