search

Giphy / giphy-android-sdk

Home of the GIPHY SDK Android example app, along with Android SDK documentation, issue tracking, & release notes.
https://developers.giphy.com/
Mozilla Public License 2.0
91 stars 40 forks source link

[UX] Preview dialog is not closed with the back button in GiphyGridView #210

Closed santi-petersen closed 10 months ago

santi-petersen commented 10 months ago

🐛 Bug Report

At least using GiphyGridView, if you long-click on a gif, a preview dialog is shown, but if you try to close it with back-button (the most intuitive way), the action is not handled and the activity finishes.

To Reproduce

  1. Long-click on a gif (using GiphyGridView)
  2. Press back button

Expected behavior

It should close the preview dialog.

Another possibility may be that we handle the back action and we close the dialog. We can enable an OnBackPressedCallback on didLongPressCell but we need a way to programmatically close the preview dialog and another event that needs to be called when the dialog is closed anyway (touching the screen, clicking "select", clicking the author or whatever) to again disable the OnBackPressedCallback

Actual Behavior

It finishes the activity

Your Environment

Reproducible Demo

ALexanderLonsky commented 10 months ago

Hey @santi-petersen, Thanks for flagging this issue! It has been resolved in the new version 2.3.10.

santi-petersen commented 10 months ago

Hey @santi-petersen, Thanks for flagging this issue! It has been resolved in the new version 2.3.10.

Brilliant! 👌