search

Giphy / giphy-android-sdk

Home of the GIPHY SDK Android example app, along with Android SDK documentation, issue tracking, & release notes.
https://developers.giphy.com/
Mozilla Public License 2.0
94 stars 37 forks source link

Update fresco dependency to latest version (3.1.1) #212

Closed danielto closed 11 months ago

danielto commented 1 year ago

Use case description

Please update fresco dependency to latest version 3.1.1

Proposed solution

Update fresco to latest version (3.1.1)

Additional contexts

Latest fresco library (3.1.1) is using the latest LibWebP library (1.3.2) that is solving security vulnerability CVE-2023-4368 https://github.com/facebook/fresco/commit/58af8bcf5c27ad63f8991536f8acabf4fe258c3c

Thank you!

ALexanderLonsky commented 1 year ago

Hey @danielto, Thanks for flagging this, we'll be releasing the version containing the requested update next week.

ALexanderLonsky commented 1 year ago

@danielto Hey, I recently tested version 3.1.1 and encountered a crash. You can find the details of the issue I faced here: https://github.com/facebook/fresco/issues/2722#issuecomment-1745730799

Unfortunately, we cannot proceed with it until it's fixed.

danielto commented 11 months ago

Hello @ALexanderLonsky,

there is a new fresco version 3.1.2. Could you please verify if it is not crashing. https://github.com/facebook/fresco/releases/tag/v3.1.2

Thank you!

ALexanderLonsky commented 11 months ago

Hey @danielto, I'm still experiencing the same crash with 3.1.2 :

FATAL EXCEPTION: FrescoIoBoundExecutor-1
Process: com.giphy.sdk.uidemo, PID: 8693
java.lang.UnsatisfiedLinkError: dlopen failed: library "libnative-imagetranscoder.so" not found

v3.1.0 is stable. I switched between the two versions and cleared the caches just to be sure.

Additionally, double checked the version dependency:

+--- com.facebook.fresco:fresco:3.1.2
|    |    +--- com.facebook.fresco:fbcore:3.1.2
|    |    +--- com.facebook.fresco:drawee:3.1.2
|    |    +--- com.facebook.fresco:imagepipeline:3.1.2
|    |    |    \--- com.facebook.fresco:imagepipeline-base:3.1.2
|    |    +--- com.facebook.fresco:imagepipeline-native:3.1.2
|    |    +--- com.facebook.fresco:memory-type-ashmem:3.1.2
|    |    +--- com.facebook.fresco:memory-type-native:3.1.2
|    |    +--- com.facebook.fresco:memory-type-java:3.1.2
|    |    +--- com.facebook.fresco:nativeimagefilters:3.1.2
|    |    +--- com.facebook.fresco:nativeimagetranscoder:3.1.2
...
ALexanderLonsky commented 11 months ago

Hey @danielto, You can opt for version 2.3.13, which includes Fresco version 3.1.3.