Support for Catalyst - Githubissues

KrisConrad commented 3 years ago

When trying to build for a mac using Catalyst I get the following error:

in /Users/kris/Desktop/Test/Pods/Giphy/GiphySDK/GiphyCoreSDK.framework/GiphyCoreSDK(GPHChannelTag.o), building for Mac Catalyst, but linking in object file built for iOS Simulator, file '/Users/kris/Desktop/Test/Pods/Giphy/GiphySDK/GiphyCoreSDK.framework/GiphyCoreSDK' for architecture x86_64

joeldrotleff commented 3 years ago

Same

jetsekoopmans commented 3 years ago

Same here...

cgmaier commented 3 years ago

hey all, thanks for bumping this up! we achieved a proof of concept for Catalyst support a while back & everything adapts surprisingly well

unfortunately we won't be able to release this until the new year

joeldrotleff commented 3 years ago

Great to hear, thanks

On Dec 16, 2020, at 11:49 AM, Christopher Maier notifications@github.com wrote:

hey all, thanks for bumping this up! we achieved a proof of concept for Catalyst support a while back & everything adapts surprisingly well

unfortunately we won't be able to release this until the new year

— You are receiving this because you are subscribed to this thread. Reply to this email directly, view it on GitHub https://github.com/Giphy/giphy-ios-sdk-ui-example/issues/126#issuecomment-746909503, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAS6TEGL45UM7KT4DRHAH73SVEFK5ANCNFSM4UNVPE5Q.

jetsekoopmans commented 3 years ago

hey all, thanks for bumping this up! we achieved a proof of concept for Catalyst support a while back & everything adapts surprisingly well

unfortunately we won't be able to release this until the new year

Good to hear! Any updates?

cgmaier commented 3 years ago

hey @jetsekoopmans and others - thanks for your patience! we've been a bit busy with our yearly planning but had a chance to dig into this today and was able to get the following podspec to work for Mac Catalyst:

pod 'Giphy', :podspec => 'https://s3.amazonaws.com/sdk.mobile.giphy.com/SDK/2.1.1-beta/Giphy.podspec'

a couple of notes:

Remove all import GiphyCoreSDK lines from your code base - everything is now consolidated into GiphyUISDK.
I also found it was necessary to add ObjC to the Other Linker Flags build setting - will be looking at understanding why this is.
I ran into some issues trying to support Mac Catalyst via Carthage installation. I plan to dig into this soon.
Feel free to try it out and share any feedback you have, just keep in mind we're yet to work with design and thoroughly test this experience.

The good news is that we're making a lot of progress switching from fat .frameworks to .xcframework, which will contribute to SPM efforts, as well as support for the new M1 Mac architectures.

Hope you're all off to a good start for the new year and staying safe out there!

jetsekoopmans commented 3 years ago

Hi @cgmaier,

Thanks for taking the time to update. The 2.1.1-beta is working when building for a simulator, my mac and 'Any Mac (Apple Silicon, Intel)'!

But when building for 'Any iOS Device (arm64)' I get the following errors:

unable to load standard library for target 'arm64-apple-ios10.0-simulator'
Failed to build module 'GiphyUISDK' from its module interface; it may have been damaged or it may have triggered a bug in the Swift compiler when it was produced

cgmaier commented 3 years ago

thanks so much for testing @jetsekoopmans ! will take a look

cgmaier commented 3 years ago

hey @jetsekoopmans any thoughts on how to reproduce? I'm able to successfully build Any iOS Device (arm64)

joeldrotleff commented 3 years ago

I just tried installing the SDK @cgmaier listed and got a Catalyst build going successfully, and tested showing the Giphy menu as well anad that worked great.

I already had -Objc in Other Linker Flags, so not sure if that is necessary or not.

Sounds like others weren't so lucky so in case it's helpful here's some info:

My Xcode: 12.3 SDK minimum: 13.0 Cocoapods: 1.10.0 Mac: 11.1

cgmaier commented 3 years ago

hey @joeldrotleff thanks for the confirm! @jetsekoopmans is it possible your issue is just a matter of cleaning / clearing derived data?

jetsekoopmans commented 3 years ago

Got it. I had to clear derived data and update cocoapods to the latest version.

Thanks for the help @cgmaier and of course for the update! 👍

cgmaier commented 3 years ago

sweet! official release notes here:

https://github.com/Giphy/giphy-ios-sdk-ui-example/releases/tag/v2.1.1

AdamBCo commented 3 years ago

@cgmaier Unfortunately I'm running into the same problem.

Our app builds locally with the GiphySDK installed via cocoapods, but fails when going through the deployment process on Bitrise.

The complaint is: ❌ ld: symbol(s) not found for architecture x86_64

I also tried using the following beta, but no luck as well:

pod 'Giphy', :podspec => 'https://s3.amazonaws.com/sdk.mobile.giphy.com/SDK/2.1.0/Giphy.podspec'

This version produces the same result.

What would you suggest we do? What information do you need to help solve the problem?

Thanks!

My Xcode: 12.3 SDK minimum: 12.0 Cocoapods: 1.10.0 Mac: 10.15.6 Catalina

cgmaier commented 3 years ago

hey @AdamBCo - is the error message specific to the GIPHY SDK? I'm not too familiar with Bitrise - I take it you can successfully build with the GIPHY integration removed?

can you successfully archive locally?

I think that this issue is likely unrelated to Mac Catalyst support (and the under-the-hood switch the .xcframework), as those were added in the latest release 2.1.1 - can you open a new issue?

Giphy / giphy-ios-sdk

Support for Catalyst #126