search

Giphy / giphy-ios-sdk

Home of the GIPHY SDK iOS example app, along with iOS SDK documentation, issue tracking, & release notes.
https://developers.giphy.com/
Mozilla Public License 2.0
116 stars 52 forks source link

Emojis that require skin tone selection are not tappable in landscape #233

Closed xmollv closed 9 months ago

xmollv commented 1 year ago

🐛 Bug Report

Emojis that require the user to select a skin tone (or a variation of the emoji) are not selectable when the device is in landscape. I'm attaching a video of me demonstrating the issue using the provided sample project on this repo (the Swift one).

To Reproduce

  1. Launch the sample project (Swift one) adding your Giphy API key.
  2. Tap on the Giphy icon
  3. On the modal, select the smiley face (emojis) tab, that'd be the 4th
  4. Verify that you can tap on the 👍🏼 emoji in portrait
  5. Rotate to landscape
  6. Verify that none of the emojis that ask you to pick a color work now

Expected behavior

The same popup to pick a skin tone should appear so the user can select it.

Actual Behavior

The popup to select the skin tone doesn't appear if the device is in landscape.

Your Environment

Reproducible Demo

https://github.com/Giphy/giphy-ios-sdk/assets/8229382/ad78bcb7-82dd-499b-aac7-d94fb2354098

xmollv commented 1 year ago

@cgmaier just pinging you because we've started getting feedback from our users. Is this something that we can solve from our side or does it need to be fixed at the SDK level? 🙏🏼

cgmaier commented 1 year ago

hey @xmollv sorry for the late reply. thanks for sharing this! we were unable to support landscape for the emoji skin tone selection feature.

we'd love to hear more from you about your experience using GIPHY emoji and any user feedback you can share. could you send any insights to integrations@giphy.com ?

xmollv commented 1 year ago

hey @xmollv sorry for the late reply. thanks for sharing this! we were unable to support landscape for the emoji skin tone selection feature.

we'd love to hear more from you about your experience using GIPHY emoji and any user feedback you can share. could you send any insights to integrations@giphy.com ?

I've passed it along to our product team and they'll get in touch on the provided email. Thanks!

cgmaier commented 1 year ago

@xmollv that's so awesome, really appreciate it! super helpful to us as we haven't been aware of any apps using the emoji feature. thanks for using the library!