search

Giphy / giphy-ios-sdk

Home of the GIPHY SDK iOS example app, along with iOS SDK documentation, issue tracking, & release notes.
https://developers.giphy.com/
Mozilla Public License 2.0
116 stars 52 forks source link

EmojiDrawerController #238

Closed alirast closed 1 year ago

alirast commented 1 year ago

Hello! I got an UI issue in my project and I have not found any code in docs related to my problem. Using GiphyGridController and having selected some emoji, we get different variations of this emoji (this feature is started from version 2.2.0, https://github.com/Giphy/giphy-ios-sdk/pull/211). Is it possible to disable this feature or to edit the interface of EmojiDrawerController? Thank you in advance.

cgmaier commented 1 year ago

thanks for the feedback, I'll pass this along. we should be able to add a flag to disable emoji variations. any reason in particular you'd like to do this ?

alirast commented 1 year ago

Thank you so much for the answer. I don't have really strong reason to disable emoji variations. Sure, I would like to keep it, but just after modifying GiphyGridController to a smaller size I have an issue - the view of emoji variations (EmojiDrawerController) overlaps the big part of GiphyGridController and it's not comfortable for the user to choose any variant of emoji.

cgmaier commented 1 year ago

hey @alirast I'll go forward with adding the ability to disable emoji variations, but can you please share a screenshot of the UI issue you experienced? maybe we can fix it in a future version.

cgmaier commented 1 year ago

hey @alirast the latest release provides the ability to disable emoji variations (for GiphyGridController only - not GiphyViewController) https://github.com/Giphy/giphy-ios-sdk/releases/tag/v2.2.7

alirast commented 1 year ago

@cgmaier Hello, sorry for late answer. Thank you for improving that feature for using emoji variations! Now everything works so properly. Thank you!