search

Giphy / giphy-ios-sdk

Home of the GIPHY SDK iOS example app, along with iOS SDK documentation, issue tracking, & release notes.
https://developers.giphy.com/
Mozilla Public License 2.0
116 stars 52 forks source link

Apple Privacy Manifest Requirement #247

Closed mikemike396 closed 6 months ago

mikemike396 commented 8 months ago

Starting May 1st, 2024 Apple will require developers to include approved reasons for the listed APIs used by your app’s code to upload a new or updated app to App Store Connect.

Running this shell script I see Giphy marked as using NSUserDefaults

Used symbols in binary ./GiphyUISDK.framework/GiphyUISDK: NSUserDefaults

Resources:

https://developer.apple.com/news/?id=3d8a9yyh https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_use_of_required_reason_api https://developer.apple.com/documentation/bundleresources/privacy_manifest_files/describing_data_use_in_privacy_manifests

Thank you

cgmaier commented 7 months ago

hey @mikemike396, thanks for flagging for us. we are working on this and will keep you in the loop!

DragonCherry commented 7 months ago

Are there any plans to apply it to version 2.1.x separately as well? For some of the legacy systems I run, we are using fixed version of 2.1.x for some reasons.

cgmaier commented 7 months ago

Hey @DragonCherry, unfortunately this may not be possible for us. However, you should be able to list the use of NSUserDefaults in your app's own privacy manifest file to comply with the App Store requirements.

The SDK uses user defaults to support the recently picked and recent searches features built into the templated experience - we've found an alternative for supporting those features so will be removing our use of the API in the next release.

Are your reasons for sticking with the 2.1.x versions compiler version related or is there something we might be able to do / fix to get your running the latest nd greatest?

DragonCherry commented 7 months ago

It's not a problem with the framework you provide, thanks anyway 👍

a1cooke commented 7 months ago

Hi, We are getting pretty close to May 1 is there a timeline for a release that contains the Privacy Manifest?

cgmaier commented 7 months ago

hey @a1cooke / all, thanks for your patience! just pushed a new version. let me know if you have any issues

a1cooke commented 7 months ago

Thanks so much @cgmaier! Will the updates to Cocoapods propagate shortly also?