GiphyDialog not reproduce gifs

bsjaramillo commented 11 months ago

🐛 Bug Report

When GiphyDialog is showing, no one gif reproduce, all items looks like static images, not gifs.

To Reproduce

Import GiphySDK and configure apiKey
Import GiphyDialog and add onDismiss and onMediaSelect events in useEffect
Add button to call GiphyDialog.show()
Press the button

Expected behavior

I expect open GiphyDialog and see gifs, not static images.

Actual Behavior

After apply to production apiKey, GiphyDialog shows static images, not gifs. In development apiKey mode, GiphyDialog was showing gifs.

Additional, I upgraded react-native, before I was using 0.70, now I'm in 0.73.

Your Environment

Giphy React Native SDK version: 3.2.1
React Native version: 0.73
Platform(s) (iOS, Android, or both?): Android
Device info (Simulator/Device? OS version? Debug/Release?): All of these.

ALexanderLonsky commented 11 months ago

Hey @bsjaramillo, Thanks for flagging this! It seems that as of RN version 0.73, they force using the latest Fresco version, which is 3.1.3. The Giphy SDK currently uses Fresco version 2.5.0 due to past dependency issues with Fresco 3.1.3 and older RN versions. To fix your problem, you need to explicitly use Giphy Android SDK version 2.3.13. To do this, just add the following block to your android build.gradle(:app) right before the dependencies section:

configurations.all {
       resolutionStrategy {
           forcedModules = ['com.giphy.sdk:ui:2.3.13']
       }
   }

bsjaramillo commented 11 months ago

ok, thanks, I'll try

Giphy / giphy-react-native-sdk