search

Giphy / giphy-react-native-sdk

GIPHY React Native SDK
https://developers.giphy.com
Apache License 2.0
69 stars 25 forks source link

Upgrade Giphy iOS SDK to at least 2.2.11 for Xcode 16/iOS 18 compatibility #198

Closed MegaMaddin closed 1 month ago

MegaMaddin commented 1 month ago

🐛 Bug Report

Using the latest version of the RN SDK crashes on Xcode16 / iOS 18 when using GiphyGridView. This was fixed with the iOS SDK release 2.2.11.

To Reproduce

  1. Build app with Xcode 16 for an iOS 18 simulator
  2. Open a view including GiphyGridView as a child
  3. App crashes when view tries to display images

Expected behavior

Using the SDK shouldn't lead crash.

Actual Behavior

Using the SDK lead to a crash.

Your Environment

Reproducible Demo

  1. Build app with Xcode 16 for an iOS 18 simulator
  2. Open a view including GiphyGridView as a child
  3. App crashes when view tries to display images

Fix

Raising the pod dependency of Giphy to 2.2.11 fixes the issue.

ALexanderLonsky commented 1 month ago

Hey @MegaMaddin, thanks for flagging this! We are aware of the issue and plan to release another version of the iOS SDK this week, which will include the fix for another critical crash. The React Native release will follow shortly after.

ALexanderLonsky commented 1 month ago

The new version has been released.

MegaMaddin commented 1 month ago

Awesome @ALexanderLonsky - feel free to resolve this issue!