Giphy / giphy-react-native-sdk

GIPHY React Native SDK
https://developers.giphy.com
Apache License 2.0
69 stars 25 forks source link

Giphy Dialog Attribution images #199

Closed TomAtterton closed 4 weeks ago

TomAtterton commented 1 month ago

Duplicates

Latest version

Summary 💡

Shouldn't we add the Attribution images to the dialog if it's required to get a production key?

Motivation 🔦

Simplify production submissions

cgmaier commented 1 month ago

hey @TomAtterton,

If you're using the dialogue or have a custom search bar with the text, "Search GIPHY", that should be sufficient to meet our attribution requirements. Ideally, developers will also use the GPHMediaView for share contexts outside of the search experience, which briefly presents a small GIPHY watermark in the corner before fading out, but we understand this view isn't great for all use cases.

Was your production key rejected? Let us know and we can take a look.

mrdanielm commented 1 month ago

hey @TomAtterton,

If you're using the dialogue or have a custom search bar with the text, "Search GIPHY", that should be sufficient to meet our attribution requirements. Ideally, developers will also use the GPHMediaView for share contexts outside of the search experience, which briefly presents a small GIPHY watermark in the corner before fading out, but we understand this view isn't great for all use cases.

Was your production key rejected? Let us know and we can take a look.

I've just requested a production key using the approach you've suggested above, "Search GIPHY" and the GIPHY watermark that fades out. Let me know if that's suitable

TomAtterton commented 4 weeks ago

@cgmaier Thanks I sent this when I submitted just incase there was something I needed to add but indeed like you said this was enough for approval 🥳

I will close this now thanks for quick response!