Giphy / giphy-react-native-sdk

GIPHY React Native SDK
https://developers.giphy.com
Apache License 2.0
68 stars 25 forks source link

iOS bottom row theme is wrong when device is in dark mode but theme prop is "light" #89

Closed efstathiosntonas closed 1 year ago

efstathiosntonas commented 1 year ago

🐛 Bug Report

iOS bottom row theme is wrong when device is in dark mode but theme prop is light.

To Reproduce

(Write your steps here:)

  1. Set iPhone on dark mode from settings
  2. Use light theme prop on GiphyDialog
  3. Bottom row colors and background are wrong (sickers, emojis etc)

Expected behavior

I'm expecting the bottom row to be the same like when device is in light theme mode.

Actual Behavior

Bottom row colors are wrong when device is in dark mode but the theme prop is light. Please see attached screenshots and device theme/prop theme combos:

This is Device in dark mode, theme prop is light:

Screenshot 2022-12-13 at 08 55 55

This is device light mode, theme prop light:

Screenshot 2022-12-13 at 08 56 56

this is device light mode, theme prop dark:

Screenshot 2022-12-13 at 08 58 29

this is device dark mode, theme prop dark:

Screenshot 2022-12-13 at 08 59 09

Your Environment

pshoniuk commented 1 year ago

Hi @efstathiosntonas, thank you for the detailed report. We will release a fix in the next version. When it becomes available, I will post the update here.

efstathiosntonas commented 1 year ago

Thanks @pshoniuk! keep it up!

efstathiosntonas commented 1 year ago

Hi @pshoniuk, any updates on this issue? Thanks

pshoniuk commented 1 year ago

Hi @efstathiosntonas! Sorry for the delayed response. We've prepared a fix for the iOS SDK and will release a fix for the React Native SDK next week.

efstathiosntonas commented 1 year ago

Great, thanks!

pshoniuk commented 1 year ago

Hi @efstathiosntonas, we released a fix in v2.1.1

efstathiosntonas commented 1 year ago

Hi @pshoniuk, thanks, will try it asap.

efstathiosntonas commented 1 year ago

@pshoniuk totally forgot about it, it works as it should now, thanks for closing it.

pshoniuk commented 1 year ago

Don't worry. It's nice to hear that everything is working as expected!