search

GiraffaFS / giraffa

Giraffa FileSystem (Slack: giraffa-fs.slack.com)
https://giraffa.ci.cloudbees.com
Apache License 2.0
17 stars 6 forks source link

Adding .idea folder to the .gitignore #101

Closed ghost closed 9 years ago

shvachko commented 9 years ago

+1 Let's make sure we follow the commit message format pattern. This one should say: Issue 101: Adding .idea folder to the .gitignore. (Cos)

shvachko commented 9 years ago

And we still updating CHANGES.txt with each commit. May need to add new section for 0.1.1 release.

ghost commented 9 years ago

Thanks, Two points about CHANGES.txt

  1. shall it be done about trivial non-product changes like this?
  2. manual update of the changes could be optimised and done automatically. What we do in Bigtop is simply grabbing the list of the issues addressed in the release and populate the changes file in one set. IMO it is less painful and way easier as RE is doing this usually.

What do you think?

shvachko commented 9 years ago

We routinely do this for all changes, without distinguishing between small or big, trivial or not. We can get rid of CHANGES.txt, which is redundant, given the commit messages allow restoring issue numbers. Let's make an issue for removing CHANGES.txt. We should also add pre-commit hook in that jira, which enforces the commit message format.

shvachko commented 9 years ago

Committed. Thank you Cos.