search

GiraffaFS / giraffa

Giraffa FileSystem (Slack: giraffa-fs.slack.com)
https://giraffa.ci.cloudbees.com
Apache License 2.0
17 stars 6 forks source link

Change trunk SNAPSHOT version to 0.2 #105

Closed shvachko closed 9 years ago

shvachko commented 9 years ago

Trunk should be 0.2-SNAPSHOT, rather than 0.1.1-SNAPSHOT

shvachko commented 9 years ago

Could you get rid of re-formatting changes, please. They are not the subject of this issue.

octo47 commented 9 years ago

That was done by mvn release:update-versions -DautoVersionSubmodules=true. I didn't do that by hand :). Next time we will call this thing it will do the same.

octo47 commented 9 years ago

done.

shvachko commented 9 years ago

Yeh, different tools format differently. My Eclipse would probably do something else. You can just edit the pom.xml files. One more thing. The commit message should be like this: Issue 105: Update trunk version to 0.2-SNAPSHOT. (Andrey) vs. yours issue-105 update version to 0.2-SNAPSHOT

shvachko commented 9 years ago

+1. Modular you amend the commit message before pushing.

octo47 commented 9 years ago

So we need to have only one commit? Not long ago amend with push -f did work properly with pull-requests. Need to write contribute rules somewhere.

shvachko commented 9 years ago

Yes, the rules are here: https://github.com/GiraffaFS/giraffa/wiki/Contribution#sharing-code-changes Did you read them?

octo47 commented 9 years ago

Now yes. Thank you.

shvachko commented 9 years ago

Just committed. Thank you Andrey.

shvachko commented 9 years ago

Forgot to add to CHANGES.txt. Should add on a next commit.