Fix post-upgrade warnings.

GiraffaFS / giraffa

Giraffa FileSystem (Slack: giraffa-fs.slack.com)

https://giraffa.ci.cloudbees.com

Apache License 2.0

17 stars 6 forks source link

Fix post-upgrade warnings. #140

Closed shvachko closed 9 years ago

shvachko commented 9 years ago

In HBase 1.0 some APIs that Giraffa used are deprecated. Should fix these warnings. Some examples: HTableInterface extends Table, HBaseAdmin, put.add()...

shvachko commented 9 years ago

Also remove unused imports in TestGiraffaFSContract.

milandesai commented 9 years ago

Looks good, but a couple more minor things we can fix. In INodeManager.getListing(...), we shouldn't throw AccessControlException, FileNotFoundException, and UnresolvedLinkException. We can remove those and their imports. Additionally, in BlockManagementAgent, we can remove unused method getGiraffaBlockName(Block) and the import for Block. Other than that, looks good.

shvachko commented 9 years ago

For INodeManager.getListing() I guess it is ok to remove those. We may need to restore them with future implementation of permissions and symLinks. Unless NamespaceProcessor.getListing() will take care of them.
Good catch with getGiraffaBlockName(). Looks like only getGiraffaBlockPath() is needed.
I also removed getKeyValues(). It doesn't look we need to copy Cells from the put anymore.

milandesai commented 9 years ago

Looks good, +1

shvachko commented 9 years ago

There are still a few warnings remaining btw, in GiraffaWebServer and GiraffaWebObserver. They related to the fact that HBase switched from a.o.h.HttpServer to HttpServer2. Will create another jira for that.

shvachko commented 9 years ago

Just committed.