search

GiraffaFS / giraffa

Giraffa FileSystem (Slack: giraffa-fs.slack.com)
https://giraffa.ci.cloudbees.com
Apache License 2.0
17 stars 6 forks source link

Unused member monitor in NamespaceProcessor. #183

Closed shvachko closed 8 years ago

shvachko commented 9 years ago

NamespaceProcessor.monitor is never used, should be removed. Was introduced by #133.

pjeli commented 8 years ago

+1.

weilintsaiWand commented 8 years ago

+1

shvachko commented 8 years ago

Changes are:

  1. Removed NamespaceProcessor.monitor member.
  2. Renamed getMonitor() to initializeMonitor() because this is what it does.
  3. Replaced Preconditions with assert. Let's not introduce unnecessary dependencies, it is hard get rid of them.

Thanks for the reviews, guys.

shvachko commented 8 years ago

Committed.