Fix typos - Githubissues

GiraffaFS / giraffa

Giraffa FileSystem (Slack: giraffa-fs.slack.com)

https://giraffa.ci.cloudbees.com

Apache License 2.0

17 stars 6 forks source link

Fix typos #187

Closed shvachko closed 9 years ago

shvachko commented 9 years ago

Found a couple of typos:

HLMAdapter: LeasManager
BlockManagementAgent: remporary

If you see more add them here.

weilintsaiWand commented 9 years ago

I reviewed all java files and found:

BlockManagementAgent: seperate
DirectoryTable: objout, may be objOut?
RowKeyBytes:compatibality

Please note that I only review those typo warnings reported by Intellij. Hence, I may miss some typos such as LeasManager since leas is a valid word to Intellij.

shvachko commented 9 years ago

Yes objOut is more consistent with our naming conventions.

weilintsaiWand commented 9 years ago

How about groupname in many files (should be groupName?). Other similar words are mtime, atime, diskspaceQuota, blocksize.

weilintsaiWand commented 9 years ago

Have a initial patch to fix LeasManager/remporary/seperate/objout/compatibality. Will update if we need update groupname and its similar words

shvachko commented 9 years ago

+1 on the patch. I can live with groupname for now. But let's pay more attention on naming conventions in the future.

shvachko commented 9 years ago

Could you assign this issue to yourself please.