Closed dsalychev closed 9 years ago
How about mentioning hbase-1.0.1 and hadoop-2.5.1?
Btw, I've update wiki page https://github.com/GiraffaFS/giraffa/wiki/Introduction-and-requirements-for-Giraffa https://github.com/GiraffaFS/giraffa/wiki/How-to-Setup,-Build,-and-Use-Giraffa
I think, they are hbase-1.0.0+ and hadoop-2.5.0+, aren't they?
Good idea to update README. Let's say Java 1.7+. Because
Array<>
construct requires Java >= 1.7. Not that we cannot avoid it, but supporting 1.6 is a restriction at this point.You also need to amend the commit message. It should be formatted as described in step 6 of https://github.com/GiraffaFS/giraffa/wiki/Contribution#sharing-code-changes Also pre-commit hook should help: https://github.com/GiraffaFS/giraffa/wiki/Contribution#configuring-pre-commit-hook
Looks good. Only one quick question: I see README.txt is still existed, should we delete it ?
I removed it, just forgot to remove it within first commit.
I just committed this. Congratulations Dmitry!
For the future. It is ok to put multiple commits in the same push request. They will be squashed into a single commit anyways.
Compilation error with protoc version 2.6.1 Sure, I have to compile it with 2.5.0 version, but I think it's ok to mention it in README.txt.