search

GiraffaFS / giraffa

Giraffa FileSystem (Slack: giraffa-fs.slack.com)
https://giraffa.ci.cloudbees.com
Apache License 2.0
17 stars 6 forks source link

Unnecessary Assertion in TestLeaseRecovery #197

Closed milandesai closed 8 years ago

milandesai commented 8 years ago

I made a mistake in the fix for #188. On line 173 of TestLeaseManagement, INode.getINode may return null, which is supposed to be ok (it will retry 100 times). But I call INodeFile.valueOf on it, which will cause a NullPointerException unless the test succeeds on the first attempt. @weilintsaiWand, is this related to any of the race condition test failures you are seeing? I don't think it would be since we only committed this yesterday.

milandesai commented 8 years ago

False alarm. The only way a NullPointerException would occur is if the file somehow disappeared; not something we need to check for in lease testing. The assertion statement has a misleading description though (and is now unnecessary due to the INode.valueOf) and should be removed.