GiraffaFS / giraffa

Giraffa FileSystem (Slack: giraffa-fs.slack.com)
https://giraffa.ci.cloudbees.com
Apache License 2.0
17 stars 6 forks source link

GRFA_NAMESPACE_SERVICE_DEFAULT should be declared as NamespaceService class #232

Closed shvachko closed 7 years ago

shvachko commented 7 years ago

Currently it is declared as NamespaceAgent, which is HBase-specific not generic.

shvachko commented 7 years ago

Trivial patch is here:

diff --git a/giraffa-core/src/main/java/org/apache/giraffa/GiraffaConfiguration.java b/giraffa-core/src/main/java/org/apache/giraffa/GiraffaConfiguration.java
index a4c981b..329f366 100644
--- a/giraffa-core/src/main/java/org/apache/giraffa/GiraffaConfiguration.java
+++ b/giraffa-core/src/main/java/org/apache/giraffa/GiraffaConfiguration.java
@@ -34,8 +34,8 @@
   public static final Boolean GRFA_CACHING_DEFAULT = true;
   public static final String  GRFA_NAMESPACE_SERVICE_KEY = 
                                   "grfa.namespace.service.class"; 
-  public static final Class<NamespaceAgent> GRFA_NAMESPACE_SERVICE_DEFAULT =
-                                  NamespaceAgent.class;
+  public static final Class<? extends NamespaceService>
+                GRFA_NAMESPACE_SERVICE_DEFAULT = NamespaceAgent.class;
   public static final String  GRFA_HDFS_ADDRESS_KEY = "grfa.hdfs.address";
   public static final String  GRFA_HDFS_ADDRESS_DEFAULT = "file:///";
   public static final String  GRFA_HBASE_ADDRESS_KEY = "grfa.hbase.address";
milandesai commented 7 years ago

+1

shvachko commented 7 years ago

Just committed this. Thanks Milan for review.