search

GiraffaFS / giraffa

Giraffa FileSystem (Slack: giraffa-fs.slack.com)
https://giraffa.ci.cloudbees.com
Apache License 2.0
17 stars 6 forks source link

Move HBase related logic in NamespaceProcessor to new class #96

Closed shvachko closed 9 years ago

shvachko commented 9 years ago

Original issue 96 created by shvachko on 2015-04-15T18:42:58.000Z:

The logic for retrieving, updating, and deleting an INode from HBase, along with any other HBase-specific logic, should be moved to a new class to make NamespaceProcessor more compact and easier to work with.

shvachko commented 9 years ago

Comment #2 originally posted by shvachko on 2015-04-15T18:48:31.000Z:

Attached patch creates an INodeManager class that contains methods for retrieving, updating, and deleting an INode. It also contains a "map" method that scans the table and applies the given Function to each INode it obtains. This allows NamespaceProcessor to operate on INode listings while leaving the row scanning logic to INodeManager.

shvachko commented 9 years ago

Comment #3 originally posted by shvachko on 2015-04-15T19:04:39.000Z:

I also moved the static deserialization methods to a new class, RowDataDeserializer.

shvachko commented 9 years ago

Reviewed Milan's patch. Good refactoring.

  1. Convert CR/LF to Linux style.
  2. Need Apache license in the new file headers.
  3. Should add JavaDoc describing new classes.
  4. Don't need INodeManager.conf. Just extract tableName in constructor.
  5. Check for long lines.
shvachko commented 9 years ago

Made all the changes above. Also renamed RawDataDeserializer to FileFieldDeserializer. Will commit now with credit to Milan.

shvachko commented 9 years ago

Committed. Thank you Milan.