search

GirafiStudios / Ping

12 stars 9 forks source link

Slightly improved U.S. English translation #11

Closed Greg-21 closed 5 years ago

Greg-21 commented 5 years ago

This time I changed only "Opens Ping menu" to "Open Ping menu" to be consistent with vanilla Minecraft keybinding descriptions, which all use imperative mood (exceptions are: "hotbar slot" and "advancements"), and "Ping bloops" to "Ping bloop", since the ping sound is single.

And similarly as in #10, if you still don't agree with these changes, feel free to close this PR, and I will focus on Polish translation instead :D

GirafiStudios commented 5 years ago

Changing Opens to Open I agree with. You're still wrong with the sound, it's not grammatically correct when you remove the S, since the sound is an action that is currently happening.

Greg-21 commented 5 years ago

Do you mean word "bloop(s)" is a verb? All the time I was thinking that it was a word from the onomatopoeia process. And as such it shouldn't have the "s". But it looks like I was wrong.