Open squillero opened 1 year ago
h
Use markdown in README if you use .md extension (Check out: GitHub Flavored Markdown Spec)
.md
If you need to comment out cells, use something like if VAR_ENABLED:
if VAR_ENABLED:
Don't commit __pycache__, use .gitignore
__pycache__
.gitignore
Why name a variable frozenset_ if it actually a numpy ndarray?
frozenset_
is_valid looks like an in operator, why not using the real in (and perhaps sets)
is_valid
in
REVIEW BY SQUILLERO
MAJOR
hreally admissible? I don't think so. It should never overestimates the actual cost to the solution. You found the solution in 467,479, I found it in 14,095 with Dijkstra... but Dijkstra should be worse tha A* ;-)MINOR
Use markdown in README if you use
.mdextension (Check out: GitHub Flavored Markdown Spec)If you need to comment out cells, use something like
if VAR_ENABLED:Don't commit
__pycache__, use.gitignoreWhy name a variable
frozenset_if it actually a numpy ndarray?is_validlooks like aninoperator, why not using the realin(and perhaps sets)