Girbons / comics-downloader

tool to download comics and manga in pdf/epub/cbr/cbz from a website
MIT License
453 stars 48 forks source link

Makefile: remove separate linux build targets for different architecture #104

Closed anjandev closed 2 years ago

anjandev commented 2 years ago

This makes packaging on linux much harder. Go build already detects the correct architecture. Using this patch, you can create and cross compile binaries for linux as such:

pinephone:~/code/comics-downloader$ export GOARCH=arm64 pinephone:~/code/comics-downloader$ rm -rf build/ pinephone:~/code/comics-downloader$ make linux-build pinephone:~/code/comics-downloader$ export GOARCH=amd64 pinephone:~/code/comics-downloader$ rm -rf build/ pinephone:~/code/comics-downloader$ make linux-build

closes #103

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 120


Totals Coverage Status
Change from base Build 119: 0.0%
Covered Lines: 740
Relevant Lines: 1284

💛 - Coveralls