couldn't perform GET request

[bashfulrobot]

Describe the bug A clear and concise description of what the bug is.

I cannot download anything; I see an update error and an error stating that it couldn't open a GET. See the full error in the reproduce section.

To Reproduce Steps to reproduce the behavior:

# ./comics-downloader -url=https://comicextra.me/comic/the-weatherman-2024 -all -debug
ERRO[0000] There was an error while checking for a new comics-downloader version
INFO[0000] Downloading...
ERRO[0000] couldn't perform GET request to https://comicextra.me/comic/the-weatherman-2024

It is odd that the -debug option did not add any details.

Expected behavior A clear and concise description of what you expected to happen.

I would have expected the comics to be downloaded.

Desktop (please complete the following information):

• OS:NIXOS, but running in an ubuntu docker container.
• Version 0.33.8
• Type cli

Additional context Add any other context about the problem here.

[Girbons]

Thanks for the report @bashfulrobot!

[Girbons]

could you please try this out if it solves the issue? there's the fix even for #144

[bashfulrobot]

It has not.

❯ comics-downloader -url=https://comicextra.me/comic/the-weatherman-2024 -all -debug
exec: Failed to execute process: '/etc/profiles/per-user/dustin/bin/comics-downloader' the file could not be run by the operating system.

I wonder if this is a NixOS thing (considering it is not your average Linux).

[bashfulrobot]

I tried using steam-run (basically creates a temporary FHS environment.)

❯ steam-run comics-downloader -url=https://comicextra.me/comic/the-weatherman-2024 -all -debug
/nix/store/khdq3r9ajyw9fz0d8c262gwj5vm4jw0x-steam-run: line 21: /etc/profiles/per-user/dustin/bin/comics-downloader: cannot execute binary file: Exec format error
/nix/store/khdq3r9ajyw9fz0d8c262gwj5vm4jw0x-steam-run: line 21: /etc/profiles/per-user/dustin/bin/comics-downloader: Success

[bashfulrobot]

It is odd, as I always use other compiled go binaries without issue. :thinking:

Does it use any dynamically linked libraries?

[Girbons]

am I doing something wrong in the makefile 👀 ? I've found a typo

linux-build: # Creates Linux
    @GOOS=linux GOARDCH=amd64   go build -o build/comics-downloader-x86-64 ./cmd/downloader

I'm going to fix and update the alpha release

[Girbons]

release updated

[bashfulrobot]

OK it's working now. That explains why the Sha256 hash changed. I was really confused there for a moment. 😂

[Girbons]

I'm glad it works now! Is the issue related to comicextra also solved?

[bashfulrobot]

THis is the issue with the GET issue. :smiley:

Both are fixed with the alpha.