search

Girbons / comics-downloader

tool to download comics and manga in pdf/epub/cbr/cbz from a website
MIT License
484 stars 53 forks source link

Error on new download - comicextra #53

Closed bashfulrobot closed 4 years ago

bashfulrobot commented 4 years ago

Version

./comics-downloader --version
comics-downloader version v0.22.0
cat /etc/lsb-release
DISTRIB_ID=Ubuntu
DISTRIB_RELEASE=19.10
DISTRIB_CODENAME=eoan
DISTRIB_DESCRIPTION="Ubuntu 19.10"

Command

./comics-downloader -url=https://www.comicextra.com/comic/xxxxxxxxxxxxx -format=cbz -all

Error

INFO[0000] Downloading...                                url="https://www.comicextra.com/comic/xxxxxxxxxxxxx"
panic: runtime error: invalid memory address or nil pointer dereference
[signal SIGSEGV: segmentation violation code=0x1 addr=0x8 pc=0x77115a]

goroutine 1 [running]:
github.com/anaskhan96/soup.findAllofem.func1(0x0, 0xc0003a8c20, 0x1, 0x1, 0x0)
    /Users/girbons/go/pkg/mod/github.com/anaskhan96/soup@v1.1.1/soup.go:370 +0x8a
github.com/anaskhan96/soup.findAllofem(0x0, 0xc0003a8c20, 0x1, 0x1, 0x7b7700, 0x7ddaa0, 0xc000127001, 0x8)
    /Users/girbons/go/pkg/mod/github.com/anaskhan96/soup@v1.1.1/soup.go:374 +0xf0
github.com/anaskhan96/soup.Root.FindAll(0x0, 0x0, 0x0, 0x8df940, 0xc0003a8c10, 0xc0003a8c20, 0x1, 0x1, 0x0, 0x0, ...)
    /Users/girbons/go/pkg/mod/github.com/anaskhan96/soup@v1.1.1/soup.go:136 +0x6c
github.com/Girbons/comics-downloader/pkg/sites.(*Comicextra).RetrieveIssueLinks(0xba55e8, 0x7ffc8b0bb1c7, 0x38, 0x1, 0x0, 0x0, 0x0, 0x0, 0x0)
    /Users/girbons/go/src/github.com/Girbons/comics-downloader/pkg/sites/comicextra.go:100 +0x423
github.com/Girbons/comics-downloader/pkg/sites.LoadComicFromSource(0xc00007ff08, 0x4, 0xc0000439e8, 0x1, 0x1, 0x0)
    /Users/girbons/go/src/github.com/Girbons/comics-downloader/pkg/sites/loader.go:70 +0xd5
github.com/Girbons/comics-downloader/cmd/app.download(0xc00007ff08, 0x0)
    /Users/girbons/go/src/github.com/Girbons/comics-downloader/cmd/app/downloader.go:76 +0x546
github.com/Girbons/comics-downloader/cmd/app.Run(0xc000043f08)
    /Users/girbons/go/src/github.com/Girbons/comics-downloader/cmd/app/downloader.go:122 +0x89
main.main()
    /Users/girbons/go/src/github.com/Girbons/comics-downloader/cmd/downloader/main.go:83 +0x245

Thank you.

Girbons commented 4 years ago

Hey @bashfulrobot, I guess that this comic has all the issues in page right?

bashfulrobot commented 4 years ago

I tried a few different comics on comicsextra. I tried the URL on the "read now" page. Selecting a few different issues and setting all pages to load at the same time. I had similar results.

Girbons commented 4 years ago

released v0.22.1