Closed Jan0660 closed 2 years ago
Changes Missing Coverage | Covered Lines | Changed/Added Lines | % | ||
---|---|---|---|---|---|
pkg/core/core.go | 4 | 6 | 66.67% | ||
pkg/sites/loader.go | 0 | 4 | 0.0% | ||
pkg/sites/common.go | 75 | 88 | 85.23% | ||
<!-- | Total: | 107 | 126 | 84.92% | --> |
Totals | |
---|---|
Change from base Build 94: | 2.7% |
Covered Lines: | 734 |
Relevant Lines: | 1194 |
Thank you for the PR @Jan0660!
The PR overall is good, just one thing, despite the sites shares the same structure I would separate them in different files 😄
Fair enough, but where should I put the shared scraping code for the sites? Don't see an existing place in the folder structure for it. Or should I not share the code between them?
Fair enough, but where should I put the shared scraping code for the sites? Don't see an existing place in the folder structure for it. Or should I not share the code between them?
Yep sharing code is fine, I was thinking about something like common.go
. What are your thoughts on that?
Fair enough, but where should I put the shared scraping code for the sites? Don't see an existing place in the folder structure for it. Or should I not share the code between them?
Yep sharing code is fine, I was thinking about something like
common.go
. What are your thoughts on that?
Done! Also added some more tests for both of the sites.
Adds support for:
Both are implemented under the same struct since they have pretty much the same document structure except for CSS class names.