Girbons / comics-downloader

tool to download comics and manga in pdf/epub/cbr/cbz from a website
MIT License
456 stars 49 forks source link

Add MangaKakalot and Manganato support #90

Closed Jan0660 closed 2 years ago

Jan0660 commented 2 years ago

Adds support for:

Both are implemented under the same struct since they have pretty much the same document structure except for CSS class names.

coveralls commented 2 years ago

Pull Request Test Coverage Report for Build 96


Changes Missing Coverage Covered Lines Changed/Added Lines %
pkg/core/core.go 4 6 66.67%
pkg/sites/loader.go 0 4 0.0%
pkg/sites/common.go 75 88 85.23%
<!-- Total: 107 126 84.92% -->
Totals Coverage Status
Change from base Build 94: 2.7%
Covered Lines: 734
Relevant Lines: 1194

💛 - Coveralls
Jan0660 commented 2 years ago

Thank you for the PR @Jan0660!

The PR overall is good, just one thing, despite the sites shares the same structure I would separate them in different files 😄

Fair enough, but where should I put the shared scraping code for the sites? Don't see an existing place in the folder structure for it. Or should I not share the code between them?

Girbons commented 2 years ago

Fair enough, but where should I put the shared scraping code for the sites? Don't see an existing place in the folder structure for it. Or should I not share the code between them?

Yep sharing code is fine, I was thinking about something like common.go. What are your thoughts on that?

Jan0660 commented 2 years ago

Fair enough, but where should I put the shared scraping code for the sites? Don't see an existing place in the folder structure for it. Or should I not share the code between them?

Yep sharing code is fine, I was thinking about something like common.go. What are your thoughts on that?

Done! Also added some more tests for both of the sites.